Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FusedStream for FuturesOrdered #2205

Merged
merged 3 commits into from Sep 5, 2020
Merged

Implement FusedStream for FuturesOrdered #2205

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5e005a
Implement `FusedStream` for `FuturesOrdered`
phil-opp Aug 31, 2020
9ee1b0f
Simplify implementation based on review comments
phil-opp Aug 31, 2020
d117233
Merge branch 'master' into fused-futures-ordered
taiki-e Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion futures-util/src/stream/futures_ordered.rs
View file
Open in desktop
@@ -1,7 +1,7 @@
use crate::stream::{FuturesUnordered, StreamExt};
use futures_core::future::Future;
use futures_core::stream::Stream;
use futures_core::task::{Context, Poll};
use futures_core::{FusedStream, task::{Context, Poll}};
use pin_project::pin_project;
use core::cmp::Ordering;
use core::fmt::{self, Debug};
Expand Down Expand Up @@ -203,6 +203,12 @@ impl<Fut: Future> FromIterator<Fut> for FuturesOrdered<Fut> {
}
}

impl<Fut: Future> FusedStream for FuturesOrdered<Fut> {
fn is_terminated(&self) -> bool {
self.in_progress_queue.is_terminated() && self.queued_outputs.is_empty()
}
}

impl<Fut: Future> Extend<Fut> for FuturesOrdered<Fut> {
fn extend<I>(&mut self, iter: I)
where
Expand Down