Enable all stable features on the playground #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume that the playground builds all crates together in a single build so activating the features from the facade will affect all other crates and there's no point in marking them individually. |
taiki-e
reviewed
Nov 11, 2019
|
also, some features depend on unstable features and require nightly rustc, so I think it is good to enable only stabilized features instead of enable all-features. |
Nemo157
changed the title
|
@taiki-e thanks, that's a good point. I've listed out just the stable features instead. |
taiki-e
reviewed
Nov 11, 2019
taiki-e
approved these changes
Nov 11, 2019
Nemo157
force-pushed
the
playground-all-features
branch
from
7d5475f
to
e3c7cb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by this u.rl.o thread, based on docs in the playground source.