Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FusedStream impl to Buffered #1967

Closed
wants to merge 1 commit into from

Conversation

jean-airoldie
Copy link

Note that the buffered method seem to be missing tests.

@taiki-e
Copy link
Member

taiki-e commented Jan 29, 2020

(Looks like the new FusedStream impl is the same as .buffered().fuse().)

@cramertj
Copy link
Member

Mhm, I don't think we should add FusedStream impls to types like this if it means storing an extra boolean, since that's equivalent to wrapping with .fuse().

@jean-airoldie
Copy link
Author

Fair enough, I agree with this reasoning. I'll close the PR.

@taiki-e
Copy link
Member

taiki-e commented Nov 7, 2020

As FuturesOrdered is now implements FusedStream (#2205), I think this can be implemented by using self.stream.is_terminated() && self.in_progress_queue.is_terminated().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants