Add Drop impl to futures::channel::mpsc::UnboundedReceiver #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-0.3.2, clients could expect to drop an UnboundedReceiver and observe that incoming messages are dropped and the channel closed. This change re-introduces this behavior for UnboundedReceiver and adds tests to prevent regressions. Note that a drop impl already exists for BoundedReceiver.
|
CI seems to be broken from a previous commit. The cargo clippy error is unrelated to this change. |
|
Seems good to me to continue to match the behavior of BoundedReceiver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-0.3.2, clients could expect to drop an UnboundedReceiver and observe
that incoming messages are dropped and the channel closed.
This change re-introduces this behavior for UnboundedReceiver and adds
tests to prevent regressions.
Note that a drop impl already exists for BoundedReceiver.