Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update futures dependency #5426

Merged
merged 1 commit into from Mar 27, 2020
Merged

Update futures dependency #5426

merged 1 commit into from Mar 27, 2020

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Mar 27, 2020

No description provided.

@NikVolf NikVolf added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Mar 27, 2020
@bkchr
Copy link
Member

bkchr commented Mar 27, 2020

Why only futures? What is with other dependencies?

@NikVolf
Copy link
Contributor Author

NikVolf commented Mar 27, 2020 •
edited

@bkchr Haven't spotted any changes in them

what 0.3.4 has is

Fixed missing Drop for UnboundedReceiver (2064)`

which we use a lot

bkchr
bkchr approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for the explanation

@bkchr
Copy link
Member

bkchr commented Mar 27, 2020

Please merge master to fix the check_warnings job.

mxinden
mxinden approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we depend on this behavior (drop receiver closing the channel) heavily within client/network e.g. with event streams.

@tomaka
Copy link
Contributor

tomaka commented Mar 27, 2020

Note that according to rust-lang/futures-rs#2064 this was only a bug in futures 0.3.3, and it was correct back in futures 0.3.2.

@bkchr bkchr merged commit 3f3fb5b into master Mar 27, 2020
@bkchr bkchr deleted the nv-update-futures branch March 27, 2020 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomaka tomaka tomaka approved these changes

@bkchr bkchr bkchr approved these changes

@mxinden mxinden mxinden approved these changes

@andresilva andresilva Awaiting requested review from andresilva andresilva is a code owner

@Demi-Marie Demi-Marie Awaiting requested review from Demi-Marie

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NikVolf @bkchr @tomaka @mxinden