Simplify implementation based on review comments

rust-lang · Aug 31, 2020 · fa749d2 · fa749d2
1 parent e5e005a
commit fa749d2
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/futures-util/src/stream/futures_ordered.rs b/futures-util/src/stream/futures_ordered.rs
@@ -95,7 +95,6 @@ pub struct FuturesOrdered<T: Future> {
     queued_outputs: BinaryHeap<OrderWrapper<T::Output>>,
     next_incoming_index: usize,
     next_outgoing_index: usize,
-    is_terminated: bool,
 }
 
 impl<T: Future> Unpin for FuturesOrdered<T> {}
@@ -111,7 +110,6 @@ impl<Fut: Future> FuturesOrdered<Fut> {
             queued_outputs: BinaryHeap::new(),
             next_incoming_index: 0,
             next_outgoing_index: 0,
-            is_terminated: false,
         }
     }
 
@@ -142,10 +140,6 @@ impl<Fut: Future> FuturesOrdered<Fut> {
         };
         self.next_incoming_index += 1;
         self.in_progress_queue.push(wrapped);
-
-        // Reset the `is_terminated` flag if we've previously marked ourselves
-        // as terminated.
-        self.is_terminated = false;
     }
 }
 
@@ -182,12 +176,7 @@ impl<Fut: Future> Stream for FuturesOrdered<Fut> {
                         this.queued_outputs.push(output)
                     }
                 }
-                None => {
-                    // We can only consider ourselves terminated once we
-                    // have yielded a `None`
-                    this.is_terminated = true;
-                    return Poll::Ready(None);
-                },
+                None => return Poll::Ready(None),
             }
         }
     }
@@ -214,9 +203,9 @@ impl<Fut: Future> FromIterator<Fut> for FuturesOrdered<Fut> {
     }
 }
 
-impl<Fut: Future> FusedStream for FuturesOrdered<Fut> {
+impl<Fut: Future> FusedStream for FuturesUnordered<Fut> {
     fn is_terminated(&self) -> bool {
-        self.is_terminated
+        self.in_progress_queue.is_terminated() && self.queued_outputs.is_empty()
     }
 }