Replaced rustc_serialize with serde #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hate everything about this, while updating I encountered a compile error in |
Kixiron
changed the title
|
I've followed the original json format, but I may have missed something, so whoever reviews make sure they're identical |
Merged
jyn514
reviewed
Apr 11, 2020
Kixiron
changed the title
jyn514
reviewed
Apr 12, 2020
|
This needs to be rebased. Also, I'm not convinced that switching everything at once is the right way to go, see e.g. #459 (comment). The added tests are great, would it be possible to add those in a separate PR? That would avoid blocking them on switching to serde. |
Kixiron
force-pushed
the
jason
branch
3 times, most recently
from
e760b83
to
66df6a4
Compare
|
Update: Waiting on #743, and then am just going to rewrite this PR entirely |
jyn514
suggested changes
May 27, 2020
jyn514
approved these changes
May 27, 2020
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc_serializeserdeandserde_jsonNotes:
This is currently broken, as handlebars hates every fiber of my being. I can't figure it out, so I'm hoping one of y'all can figure it out. I've enabled theserdefeature for it and am feeding it aserdecompatible struct, but it says thatPage<T>doesn't implementSerialize, when it does.