Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] switch to cargo_metadata instead of rewriting it #1143

Closed
wants to merge 1 commit into from
Closed

[WIP] switch to cargo_metadata instead of rewriting it #1143

wants to merge 1 commit into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 30, 2020

This doesn't work at all, but opening a PR so I don't forget to come back to it.

See serde-rs/json#727 for the motivation.

@jyn514
Copy link
Member Author

jyn514 commented Nov 22, 2020

I want to resolve rust-lang/cargo#8880 one way or another before working on this more.

@Nemo157
Copy link
Member

Nemo157 commented Nov 22, 2020

I see homepage and documentation in the cargo metadata output, is it just that cargo-metadata doesn't include it in its data structure?

@jyn514
Copy link
Member Author

jyn514 commented Nov 22, 2020

🤦 I was testing with stable, not nightly - I guess the behavior is invisibly different? That seems like a footgun.

@jyn514 jyn514 mentioned this pull request Nov 22, 2020
Closed
@jyn514
Copy link
Member Author

jyn514 commented Apr 14, 2021

This is currently blocked on oli-obk/cargo_metadata#158.

@jyn514 jyn514 force-pushed the cargo-metadata branch 2 times, most recently from ef952c4 to bfc7dc0 Compare April 14, 2021 05:29
@jyn514 jyn514 added A-builds Area: Building the documentation for a crate S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users labels Apr 14, 2021
@jyn514 jyn514 changed the title [broken] [WIP] switch to cargo_metadata instead of rewriting it [WIP] switch to cargo_metadata instead of rewriting it Apr 14, 2021
@jyn514
Copy link
Member Author

jyn514 commented Aug 21, 2023

rust-lang/team#1051

@jyn514 jyn514 closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-builds Area: Building the documentation for a crate C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jyn514 @Nemo157