Skip to content

Commit

Permalink
fix asssertion, add builds check to normal build-crate tes
Browse files Browse the repository at this point in the history
  • Loading branch information
syphar committed May 3, 2024
1 parent 99b865b commit c9281eb
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions src/docbuilder/rustwide_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1062,21 +1062,24 @@ mod tests {
let mut conn = env.db().conn();
let row = conn
.query_one(
"SELECT
r#"SELECT
r.rustdoc_status,
r.default_target,
r.doc_targets,
r.archive_storage,
cov.total_items,
b.id as build_id
b.id as build_id,
b.build_status,
b.docsrs_version,
b.rustc_version
FROM
crates as c
INNER JOIN releases AS r ON c.id = r.crate_id
INNER JOIN builds as b ON r.id = b.rid
LEFT OUTER JOIN doc_coverage AS cov ON r.id = cov.release_id
WHERE
c.name = $1 AND
r.version = $2",
r.version = $2"#,
&[&crate_, &version],
)
.unwrap();
Expand All @@ -1085,6 +1088,9 @@ mod tests {
assert_eq!(row.get::<_, String>("default_target"), default_target);
assert!(row.get::<_, Option<i32>>("total_items").is_some());
assert!(row.get::<_, bool>("archive_storage"));
assert!(!row.get::<_, String>("docsrs_version").is_empty());
assert!(!row.get::<_, String>("rustc_version").is_empty());
assert_eq!(row.get::<_, String>("build_status"), "success");

let mut targets: Vec<String> = row
.get::<_, Value>("doc_targets")
Expand Down Expand Up @@ -1400,7 +1406,7 @@ mod tests {
assert!(row.rustc_version.is_none());
assert!(row.docsrs_version.is_none());
assert_eq!(row.build_status, BuildStatus::Failure);
assert_eq!(row.errors, Some("error message".into()));
assert!(row.errors.unwrap().contains("missing Cargo.toml"));

Ok(())
});
Expand Down

0 comments on commit c9281eb

Please sign in to comment.