Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert base64 dependency upgrade #5647

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 14, 2022

This should temporarily resolve #5646 until we figure out what exactly went wrong and why the background worker still seems to be running correctly despite the Sentry error reports.

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Dec 14, 2022
@paolobarbolini
Copy link
Contributor

It probably has to do with base64 0.20 requiring correct padding by default when decoding

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 14, 2022

yeah, that's possible. I wish their changelog was a bit more explicit about changing the default behavior of their main API interface... 😩

@Turbo87 Turbo87 merged commit 3f1777d into rust-lang:master Dec 14, 2022
@Turbo87 Turbo87 deleted the revert-base64-upgrade branch December 14, 2022 20:29
@paolobarbolini
Copy link
Contributor

yeah. BTW considering all of the changes that had to be done to move to 0.20 you too might be interested in marshallpierce/rust-base64#205

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 14, 2022

oh dear... thanks for the link 🙈

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 15, 2022

why the background worker still seems to be running correctly despite the Sentry error reports.

I figured it out... I did not notice yesterday that the Sentry issues were only for the staging environment, but in production everything was working fine. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: failed to base64 decode the ssh key: InvalidPadding
2 participants