Upgrade frontend to Ember 3.0.0 #1277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned on the Ember.js Slack, I would prefer it if the PR could be broken apart into multiple PRs to make review a little easier. My suggestion would be to start with the new testing API changes, then the native-dom-helpers and finally the upgrade itself. |
Turbo87
reviewed
Mar 25, 2018
package.json
Outdated
| @@ -46,6 +46,7 @@ | |||
| "ember-cli-shims": "^1.2.0", | |||
| "ember-cli-sri": "2.1.1", | |||
| "ember-cli-uglify": "^2.0.0", | |||
| "ember-cli-update": "^0.15.0", | |||
There was a problem hiding this comment.
I'd prefer to use the global installation of this, since we don't need to install it for CI systems etc.
There was a problem hiding this comment.
Alright, commit removed.
CvX
force-pushed
the
ember-3
branch
5 times, most recently
from
22db619
to
2f6d387
Compare
Done using ember-cli-update. Doesn’t enable new ember eslint rules for now.
|
@CvX could you extract the ESLint changes to a separate PR too? Ideally all that remains in this PR will be the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Ember to version 3.0.0.