Detect msvc version if there is no default #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, these failures seem unrelated to my PR? Nothing should prevent even running tests. Looking back at other PRs it seems CI has been flaky as of late. |
Right, see #677. |
|
My remark was purely on the GitHub Actions then failure, which is unrelated to the suggested modifications. In other words I had no comment on the actual substance, and still don't. |
thomcc
approved these changes
Sep 23, 2023
There was a problem hiding this comment.
Looks good to me. I'd merge but I'll leave it to @ChrisDenton to do so.
|
I'd honestly forgotten about this PR. I'll rebase and check my working... |
ChrisDenton
force-pushed
the
detect-msvc
branch
from
0e1555c
to
755e4fe
Compare
|
lgtm, thanks Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695
If there is no default msvc version file, then this falls back to searching for other version files. This fixes an issue discovered in rust-lang/rustup#3024 where installing anything but the latest msvc version meant that rustup couldn't find it.