kmc-solid: Apply cross-build prefix by prefix_for_target instead of special-casing in get_base_compiler
#692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… special-casing in `get_base_compiler`
kawadakk
force-pushed
the
patch/kmc-solid/cross-build-prefix
branch
from
73490b9
to
8ebe400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the tool names are determined for the
*-kmc-solid_*Tier 3 targets and thereby fixesarbeing invoked without a cross-build prefix.The cross build prefixes for these targets are
arm-kmc-eabiandaarch64-kmc-elf. In the current version of cc-rs, these prefixes are added to a compiler command-line by SOLID-specific code inget_base_compiler, but no prefixes are added to an archiver (ar) command-line. This happened to work in certain versions of the SOLID standard toolchain that provided prefix-less aliases, but according to the toolchain's maintainer, their usage is discouraged.This PR removes the special case in
get_base_compilerand instead defines the cross build prefixes inprefix_for_target, the common subroutine that provides cross build prefixes for all purposes.