Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add armv7 assembly for cc-test #629

Merged
merged 1 commit into from Nov 11, 2021
Merged

Conversation

glandium
Copy link
Contributor

@glandium glandium commented Nov 3, 2021

No description provided.

@alexcrichton
Copy link
Member

Thanks! Is there any particular reason for adding this though?

@glandium
Copy link
Contributor Author

glandium commented Nov 3, 2021

I independently rediscovered #627 (since it's not in a release), and was trying to get a simple STR using cc-test to open an issue, but it was not building at all because of the lack of armv7.S.

@alexcrichton
Copy link
Member

Ah ok makes sense! FWIW I think the _asm symbol can be removed since that's just me being too lazy to use preprocessor differences to deal with macos/linux differences in the x86_64.S file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants