Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emscripten build on windows #1054

Merged
merged 1 commit into from
May 4, 2024
Merged

fix: emscripten build on windows #1054

merged 1 commit into from
May 4, 2024

Conversation

atty303
Copy link
Contributor

@atty303 atty303 commented May 4, 2024

Since family detection is performed for cmd.exe, it recognizes msvc instead of clang and passes the wrong compilation options (-nologo).

@NobodyXu
Copy link
Collaborator

NobodyXu commented May 4, 2024

cc @thomcc Could you review this please?

thomcc
thomcc approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@thomcc thomcc merged commit 8084e0f into rust-lang:main May 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atty303 @NobodyXu @thomcc