Replace println with print_warning in Build::try_get_compiler #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A println would not be seen by user unless -v is passed to cargo, using print_warning here makes more sense as user can see the message by default and also disable it if they don't want to see it.
|
Hmm, isn't this a setting they requested? Why does it make sense to warn on things the user asks for? |
Hmmm yeah...Maybe it makes more sense to remove this completely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A println would not be seen by user unless -v is passed to cargo, using print_warning here makes more sense as user can see the message by default and also disable it if they don't want to see it.