Avoid recursive calls into try_get_compiler when items are in the cache #1050

dpaoliello · 2024-05-03T23:55:25Z

Have try_get_compiler provide the compiler path to is_flag_supported, and use get_base_compiler if called externally.

src/lib.rs

NobodyXu

Thank you!

dpaoliello mentioned this pull request May 3, 2024

Performance regression between cc 1.0.90 and 1.0.91, regression is also present in 1.0.96 #1048

Closed

dpaoliello force-pushed the perf branch from 69586d6 to 0663a8f Compare May 4, 2024 00:02

NobodyXu reviewed May 4, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

dpaoliello force-pushed the perf branch from 0663a8f to 763a468 Compare May 4, 2024 00:15

NobodyXu requested changes May 4, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

NobodyXu requested changes May 4, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

Avoid recursive calls into try_get_compiler when items are in the cache

a752e34

dpaoliello force-pushed the perf branch from 763a468 to a752e34 Compare May 4, 2024 00:37

dpaoliello requested a review from NobodyXu May 4, 2024 00:43

NobodyXu mentioned this pull request May 4, 2024

Parallelise flag support check in try_get_compiler #1052

Open

NobodyXu requested changes May 4, 2024

View reviewed changes

src/lib.rs Show resolved Hide resolved

NobodyXu approved these changes May 6, 2024

View reviewed changes

NobodyXu merged commit 385228f into rust-lang:main May 6, 2024
23 checks passed

dpaoliello deleted the perf branch May 6, 2024 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid recursive calls into try_get_compiler when items are in the cache #1050

Avoid recursive calls into try_get_compiler when items are in the cache #1050

dpaoliello commented May 3, 2024

NobodyXu left a comment

Avoid recursive calls into try_get_compiler when items are in the cache #1050

Avoid recursive calls into try_get_compiler when items are in the cache #1050

Conversation

dpaoliello commented May 3, 2024

NobodyXu left a comment

Choose a reason for hiding this comment