Skip to content

Commit

Permalink
Merge pull request #792 from mqudsi/nvcc-comment
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnTitor committed Feb 18, 2023
2 parents 0d9a0f8 + 0b68d59 commit 06c1289
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3277,18 +3277,22 @@ impl Tool {
self.removed_args.push(flag);
}

/// Add a flag, and optionally prepend the NVCC wrapper flag "-Xcompiler".
/// Push a flag to the end of the compiler's arguments list.
///
/// Currently this is only used for compiling CUDA sources, since NVCC only
/// accepts a limited set of GNU-like flags, and the rest must be prefixed
/// with a "-Xcompiler" flag to get passed to the underlying C++ compiler.
/// Currently `-Xcompiler` is inserted before the passed flag when compiling
/// CUDA sources since NVCC only accepts a limited set of GNU-like flags,
/// while the rest must be prefixed with the `-Xcompiler` flag to get passed
/// to the underlying C++ compiler.
fn push_cc_arg(&mut self, flag: OsString) {
if self.cuda {
self.args.push("-Xcompiler".into());
}
self.args.push(flag);
}

/// Checks if an argument or flag has already been specified or conflicts.
///
/// Currently only checks optimization flags.
fn is_duplicate_opt_arg(&self, flag: &OsString) -> bool {
let flag = flag.to_str().unwrap();
let mut chars = flag.chars();
Expand Down Expand Up @@ -3316,7 +3320,7 @@ impl Tool {
return false;
}

/// Don't push optimization arg if it conflicts with existing args
/// Don't push optimization arg if it conflicts with existing args.
fn push_opt_unless_duplicate(&mut self, flag: OsString) {
if self.is_duplicate_opt_arg(&flag) {
println!("Info: Ignoring duplicate arg {:?}", &flag);
Expand Down

0 comments on commit 06c1289

Please sign in to comment.