Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #9102 to the 1.50 release branch #9129

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Feb 3, 2021

As per #9124 (comment) here is a backport of #9102

@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.50.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 3, 2021

📌 Commit 6c61858 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2021
@bors
Copy link
Collaborator

bors commented Feb 3, 2021

⌛ Testing commit 6c61858 with merge 8830023...

@ehuss
Copy link
Contributor

ehuss commented Feb 3, 2021

This will also need a version bump to 0.51.1.

@bors
Copy link
Collaborator

bors commented Feb 3, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 8830023 to rust-1.50.0...

@bors bors merged commit 8830023 into rust-lang:rust-1.50.0 Feb 3, 2021
@Eh2406 Eh2406 deleted the backport-serde branch February 3, 2021 22:11
@alexcrichton
Copy link
Member

Oops, indeed! @Eh2406 mind following up with a version bump?

@alexcrichton
Copy link
Member

Er scratch that, this doesn't need a bump b/c this Cargo wasn't published yet, just the stable channel needed the bump!

@ehuss ehuss added this to the 1.50.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants