Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small things to help with fuzz tests #6274

Merged
merged 5 commits into from
Nov 7, 2018
Merged

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Nov 7, 2018

These are some small fixes to make it less likely to have randomly failing tests. This also documents what to do, and not to feel guilty, if the test do fail.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406
Copy link
Contributor Author

Eh2406 commented Nov 7, 2018

@ehuss Do you think it is ok to call out pinging #6258?
@matthiaskrgr Do you think these comments would have made your experience easier?

@ehuss
Copy link
Contributor

ehuss commented Nov 7, 2018

@ehuss Do you think it is ok to call out pinging #6258?

Seems fine to me.

@matthiaskrgr
Copy link
Member

Looks good to me, thanks! :)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 7, 2018

📌 Commit 7ca46cc has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Nov 7, 2018

⌛ Testing commit 7ca46cc with merge 077087a...

bors added a commit that referenced this pull request Nov 7, 2018
Small things to help with fuzz tests

These are some small fixes to make it less likely to have randomly failing tests. This also documents what to do, and not to feel guilty, if the test do fail.
@bors
Copy link
Collaborator

bors commented Nov 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 077087a to master...

@bors bors merged commit 7ca46cc into rust-lang:master Nov 7, 2018
@Eh2406 Eh2406 deleted the small_things branch November 7, 2018 17:11
@ehuss ehuss added this to the 1.32.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants