-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toml): remove lib.plugin
key support and make it warning
#13902
base: master
Are you sure you want to change the base?
Conversation
feda71e
to
3638496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you do documentation update as well?
src/doc/src/reference/cargo-targets.md
could just indicate that “This option is deprecated and unused”.- Change this line to “mostly for support of proc-macros”.
- Any other comments or function names containing "plugin" that needs to be removed. You can hold of this a bit, as it might require extra efforts.
Personally the change is fine, though I still think it is great to ship this along with the version introduction edition 2024 (not tie to edition just merge this in the same version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you squash doc commits into one, and test commits into another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It might not be necessary, though I'd like to wait a little longer. I'll merge this once nightly 1.81 is out.
What does this PR try to resolve?
Remove
lib.plugin
key, making it an "unused key" warning.Remove some of the tests, which should look useless (I hope I'm understanding this
part of #13629
Closes #13246