Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: Discard the existence of [project] and change WARNING to ERROR #13762

Closed
wants to merge 2 commits into from

Conversation

heisen-li
Copy link
Contributor

What does this PR try to resolve?

a part of #13629

Maybe start this now? It's always good to get rid of something:)

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024
@epage
Copy link
Contributor

epage commented Apr 16, 2024

Couple of notes

@bors
Copy link
Collaborator

bors commented Apr 16, 2024

☔ The latest upstream changes (presumably #13747) made this pull request unmergeable. Please resolve the merge conflicts.

@weihanglo
Copy link
Member

Close as #13747 was just merged.

@weihanglo weihanglo closed this Apr 16, 2024
@heisen-li heisen-li deleted the package branch April 17, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants