cargo package -p no-exist emitt error when the -p package not found
#13735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
Command-package
S-waiting-on-review
linyihai
force-pushed
the
package-no-match
branch
from
b773de2
to
fb7933f
Compare
epage
reviewed
Apr 11, 2024
linyihai
force-pushed
the
package-no-match
branch
from
fb7933f
to
decbadb
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2024
Update cargo 8 commits in 74fd5bc730b828dbc956335b229ac34ba47f7ef7..48eca1b164695022295ce466b64b44e4e0228b08 2024-04-10 18:40:49 +0000 to 2024-04-12 21:16:36 +0000 - test: Remove add/remove death tests (rust-lang/cargo#13750) - feat(resolve): Fallback to 'rustc -V' for MSRV resolving (rust-lang/cargo#13743) - feat(cli): Add --ignore-rust-version to update/generate-lockfile (rust-lang/cargo#13742) - `cargo package -p no-exist` emitt error when the -p `package` not found (rust-lang/cargo#13735) - fix(help): Generalize --ignore-rust-version (rust-lang/cargo#13741) - test: don't compress test registry crates (rust-lang/cargo#13744) - feat(reslve): Respect '--ignore-rust-version' (rust-lang/cargo#13738) - refactor: Remove `rust_2024_compatibility` lint group (rust-lang/cargo#13740) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2024
Update cargo 8 commits in 74fd5bc730b828dbc956335b229ac34ba47f7ef7..48eca1b164695022295ce466b64b44e4e0228b08 2024-04-10 18:40:49 +0000 to 2024-04-12 21:16:36 +0000 - test: Remove add/remove death tests (rust-lang/cargo#13750) - feat(resolve): Fallback to 'rustc -V' for MSRV resolving (rust-lang/cargo#13743) - feat(cli): Add --ignore-rust-version to update/generate-lockfile (rust-lang/cargo#13742) - `cargo package -p no-exist` emitt error when the -p `package` not found (rust-lang/cargo#13735) - fix(help): Generalize --ignore-rust-version (rust-lang/cargo#13741) - test: don't compress test registry crates (rust-lang/cargo#13744) - feat(reslve): Respect '--ignore-rust-version' (rust-lang/cargo#13738) - refactor: Remove `rust_2024_compatibility` lint group (rust-lang/cargo#13740) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Fixes #13719
If
-pis used, and the spec doesn't match any member, we emit an error likecargo publish -pdoes.How should we test and review this PR?
The first commit add a test to show the issue, the next commit add the check logic to fix it.
Additional information