Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement RFC 3553 to add SBOM support #13709
base: master
Are you sure you want to change the base?
feat: implement RFC 3553 to add SBOM support #13709
Changes from all commits
4f15b21
d8db269
78ad753
e3bf57d
5296c9e
4a6a363
7c13dc7
cbd874f
11dc92d
9b6e7f7
def6960
fd0381a
5ba5f32
c48d65f
755fa61
5c39a4a
3656e32
96f348a
9fa3075
e9e171d
809bc80
ca659a1
1e9f5c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a dependencies field for this top-level
Sbom
?(Just a question. I don't really know if other SBOM formats need it to recover the dependency graph)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, yes. Copying my comment from the RFC:
So what I would like to see is two resolved dependency trees: one for normal dependencies and one for build dependencies, matching the way feature resolver v2 works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad news. People can override profiles for individual packages. So, only a top-level profile might not be enough to represent the build.
(The truth is, I am not an SBOM expert, so just provide information for you to consider)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point. This makes it seem like the profile needs to be captured for each package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it sufficient to only include a package's profile when it differs from the root level one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It sounds like a good idea to me. This behavior just needs to be documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share the idea of distinguishing the build script execution?
It is a bit odd that the only "crate" dependency a build script execution has is the build script "compilation".
Let me explain it a bit: In Cargo's unit graph there are two kinds of unit for build scripts. One for build script compilation, the other for execution. See this doc for more: https://doc.rust-lang.org/nightly/nightly-rustc/cargo/core/compiler/custom_build/index.html.
Yeah we got another similar question: what do we want to track in SBOM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just re-read the RFC and asked there rust-lang/rfcs#3553 (comment).