Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta-1.66] Backport fix for git2 safe-directory disable #11381

Merged
merged 3 commits into from Nov 15, 2022
Merged

[beta-1.66] Backport fix for git2 safe-directory disable #11381

merged 3 commits into from Nov 15, 2022

Commits on Nov 15, 2022

  1. Auto merge of rust-lang#11366 - ehuss:fix-safe-directory, r=epage 

    Fix git2 safe-directory disable

The call to `set_verify_owner_validation` was not getting called unless a network configuration was found. This means in the common case that `cargo new` will fail when there is a safe-directory error. This fixes the issue by making sure that `set_verify_owner_validation` is called before the early-exits in `init_git_transports`.

Fixes rust-lang#11365
    @bors @ehuss
    bors authored and ehuss committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6774bc1 View commit details
    Browse the repository at this point in the history

  2. Auto merge of rust-lang#11332 - weihanglo:fix-semver-check, r=Muscraft 

    fix(semver-check): adapt to a different error for variant not covered
    @bors @ehuss
    bors authored and ehuss committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    e3daada View commit details
    Browse the repository at this point in the history

  3. Auto merge of rust-lang#11335 - ehuss:space-test, r=epage 

    Clean more aggressively in CI

The Windows x86_64 gnu CI job is running dangerously low on disk space. This PR adds another step to delete test output more aggressively. The test output with x86_64-pc-windows-gnu is nearly 9.5GB. The benchmark step is adding about 1GB of space (unfortunately it is rebuilding cargo, which may be hard to avoid without a workspace).

Eventually we should probably look at figuring out how to reduce the amount of disk space used by the testsuite. Perhaps something like rust-lang#9701 (see comments there). Or, making aggressive changes to the tests themselves. Many tests can probably be changed to use `cargo check` instead of `cargo build` (or maybe even `cargo tree`). We can default to not generating debuginfo. Or perhaps there are other changes to put the tests on a diet.
    @bors @ehuss
    bors authored and ehuss committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    4d1d2b2 View commit details
    Browse the repository at this point in the history