Rebuild and rerun build scripts when RUSTC_WRAPPER has changed #10973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently fails on the "Reruns build script because RUSTC_WRAPPER
changes the fingerprint" step.
---- freshness::rerun_build_script_if_add_rustc_wrapper stdout ----
running `/git/cargo/target/debug/cargo check`
running `/git/cargo/target/debug/cargo check`
running `/git/cargo/target/debug/cargo build`
running `/git/cargo/target/debug/cargo check`
thread 'freshness::rerun_build_script_if_add_rustc_wrapper' panicked at 'assertion failed: file_created_by_build_script.exists()', tests/testsuite/freshness.rs:888:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
This is probably misguided unless we also add some detection for whether the output of the build script is any different from the previous run, and avoid rebuilding everything downstream in that situation. :( dtolnay/anyhow#261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The current behavior of Cargo, which I think is a bug, is that if you run
cargo buildfollowed byRUSTC_WRAPPER=… cargo build, Cargo will rebuild your crate using the given rustc wrapper, but will not rebuild or rerun any build scripts. The same is true of those commands in the opposite order: Cargo will rebuild your crate with no wrapper, but not build scripts.This PR fixes this to rebuild build scripts too (and rerun them) when RUSTC_WRAPPER has changed.
In general, whatever rationale justifies rebuilding an already successfully built crate on a RUSTC_WRAPPER change (maybe the wrapper is in charge of munging rustc flags somehow?) should apply just as much to justify rebuilding build scripts.
The immediate motivation for the PR is that we had a problematic experience in the
anyhowcrate where compiling via rust-analyzer using rust-analyzer's RUSTC_WRAPPER would break all subsequent command-line cargo invocations, due to the RUSTC_WRAPPER-using build of the build script being cached and not rerun.How should we test and review this PR?
I tested by
cargo test --test testsuite -- rerun_build_script_if_add_rustc_wrapper.