Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on latest nightly #530

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Jun 19, 2023

This was causing CI to fail.

This was causing CI to fail.
Copy link
Contributor

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the continued failure on some platforms is intentional.

@Amanieu
Copy link
Member Author

Amanieu commented Jun 19, 2023

Yes, android CI is broken because of the libunwind changes (and has been broken for a while). I can have a go at fixing it though...

@Amanieu Amanieu force-pushed the fix-glob-reexports branch 3 times, most recently from b4b4f9b to 86b5cb1 Compare June 19, 2023 23:09
@workingjubilee
Copy link
Contributor

That seems to be... less fixed, as it had 3 failures and now it has 5. Can you open an issue for the Android failures and then we can tag in the Android team?

@Amanieu
Copy link
Member Author

Amanieu commented Jun 19, 2023

Issue for Android CI: #531

@Amanieu Amanieu merged commit e9ef7d8 into rust-lang:master Jun 19, 2023
62 of 68 checks passed
@Amanieu Amanieu deleted the fix-glob-reexports branch June 19, 2023 23:48
@workingjubilee
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants