select & join #28
Merged
select & join #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
Aug 6, 2019
| async fn get_book_and_music() -> (Book, Music) { | ||
| let book_fut = get_book(); | ||
| let music_fut = get_music(); | ||
| join!(book_fut, music_fut) |
There was a problem hiding this comment.
Off-topic: Should we rewrite join!/try_join! with proc-macro to allow passing expressions directly here?
join!(get_book(), get_music())There was a problem hiding this comment.
That would be nice! I was actually just thinking the same thing.
| @@ -0,0 +1,183 @@ | |||
| #![cfg(test)] | |||
| #![feature(async_await)] | |||
|
|
|||
There was a problem hiding this comment.
Seems a recursion limit error has occurred in this crate. https://travis-ci.com/rust-lang/async-book/builds/122145149#L961
|
Another error seems to be that mio has moved to tokio-rs (https://github.com/tokio-rs/mio) and the following link is out of date. async-book/src/02_execution/05_io.md Line 112 in 822a3d3 https://travis-ci.com/rust-lang/async-book/builds/122145149#L817 |
yoshuawuyts
reviewed
Aug 8, 2019
src/06_multiple_futures/03_select.md
Outdated
|
|
||
| One thing you may have noticed in the first example above is that we | ||
| had to call `.fuse()` on the futures returned by the two `async fn`s, | ||
| as well as pinning them with `pin_mut`. Both of these calls necessary |
There was a problem hiding this comment.
Suggested change
| as well as pinning them with `pin_mut`. Both of these calls necessary | |
| as well as pinning them with `pin_mut`. Both of these calls are necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @yoshuawuyts @nikomatsakis