Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Replace #!/bin/sh with #!/bin/bash #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vi
Copy link

@vi vi commented Apr 3, 2016

Should resolve #47.

@sanmai-NL
Copy link
Contributor

I strongly prefer to rewrite in portable shell code instead, or to not use a shell script at all for this (given the relative complexity of the script). How is rustup going to work satisfactorily on various platforms otherwise?

@vi
Copy link
Author

vi commented Apr 15, 2016

rustup.sh may be obsoleted in favour of rustup.rs, so serious rewrite may be in vain.

@sanmai-NL
Copy link
Contributor

sanmai-NL commented Apr 15, 2016

The script is not that non-portable at present at all. See e.g. this comment

Revised: if rustup.rs is a suitable replacement (soon) anyway, briefly depending on /bin/bash is better than the current situation anyway.

@sanmai-NL
Copy link
Contributor

@vi: I must have missed the announcement of the alternative tool in this repo? I hope this can be clarified so that you get to see a warning immediately when browsing this repo.

@vi
Copy link
Author

vi commented Apr 15, 2016

@sanmai-NL, Main rustup.rs discussion thread is here: https://internals.rust-lang.org/t/beta-testing-rustup-rs/3316/83

@brson
Copy link
Contributor

brson commented May 3, 2016

Sorry I've been ignoring this repo. From the linked issue, none of the bashisms seem fundamental. I'd rather just fix them. This script is likely to stick around for at least a few more months.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bashisms while #!/bin/sh
3 participants