Bashisms while `#!/bin/sh` #47

vi · 2016-03-09T21:21:54Z

$ multirust update nightly
multirust: installing toolchain 'nightly'
rustup: gpg available. signatures will be verified
/home/vi/home/rust/prefix/bin/rustup.sh: 1512: [: 1: unexpected operator
rustup: downloading manifest for 'nightly'
^C

$ checkbashisms /home/vi/home/rust/prefix/bin/rustup.sh
possible bashism in /home/vi/home/rust/prefix/bin/rustup.sh line 84 ('command' with option other than -p):
    if command -v gpg2 > /dev/null 2>&1; then
possible bashism in /home/vi/home/rust/prefix/bin/rustup.sh line 88 ('command' with option other than -p):
    if command -v "$gpg_exe" > /dev/null 2>&1; then
possible bashism in /home/vi/home/rust/prefix/bin/rustup.sh line 1388 ('command' with option other than -p):
    if command -v "$sha256sum_cmd" > /dev/null 2>&1; then
possible bashism in /home/vi/home/rust/prefix/bin/rustup.sh line 1390 ('command' with option other than -p):
    elif command -v shasum > /dev/null 2>&1; then
possible bashism in /home/vi/home/rust/prefix/bin/rustup.sh line 1407 ('command' with option other than -p):
    if command -v "$sha256sum_cmd" > /dev/null 2>&1; then
possible bashism in /home/vi/home/rust/prefix/bin/rustup.sh line 1409 ('command' with option other than -p):
    elif command -v shasum > /dev/null 2>&1; then
possible bashism in /home/vi/home/rust/prefix/bin/rustup.sh line 1512 (should be 'b = a'):
            if [ $? == 0 ]; then
possible bashism in /home/vi/home/rust/prefix/bin/rustup.sh line 1787 (read with option other than -r):
    read -p "Continue? (y/N) " _yn < /dev/tty

Maybe it should be #!/bin/bash?

The text was updated successfully, but these errors were encountered:

nikolaykasyanov · 2016-03-12T14:06:26Z

I'm getting the same /home/vi/home/rust/prefix/bin/rustup.sh: 1512: [: 1: unexpected operator on Ubuntu Trusty

Should resolve rust-lang-deprecated#47.

sanmai-NL · 2016-04-15T11:57:33Z

The command -v lines are false alarms. Even under the dash shell, Debian's /bin/sh these commands work:

$ command -p whoami
sanmai
$ command -v whoami
/usr/bin//whoami

vi added a commit to vi/rustup that referenced this issue Apr 3, 2016

Replace #!/bin/sh with #!/bin/bash

aab0c67

Should resolve rust-lang-deprecated#47.

vi linked a pull request Apr 3, 2016 that will close this issue

Replace #!/bin/sh with #!/bin/bash #50

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bashisms while `#!/bin/sh` #47

Bashisms while `#!/bin/sh` #47

vi commented Mar 9, 2016

nikolaykasyanov commented Mar 12, 2016

sanmai-NL commented Apr 15, 2016

Bashisms while #!/bin/sh #47

Bashisms while #!/bin/sh #47

Comments

vi commented Mar 9, 2016

nikolaykasyanov commented Mar 12, 2016

sanmai-NL commented Apr 15, 2016

Bashisms while `#!/bin/sh` #47

Bashisms while `#!/bin/sh` #47