Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Various compat changes for recent rusts #198

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kentfredric
Copy link

I'm aware that this is officially deprecated.

This set of changes is prompted by having things that continue to require rustc-serialize in some capacity, and the desire as a vendor to ensure that rustc-serialize thus continues to be usable.

Fixing the tests is required to help us ensure it continues to be usable, because tests help identify when a mechanism breaks.

Alas, due to the derive macro's no longer seeming to exist, I've had to exorcise all tests that relied on those macros.

Some of these changes are also spurred on by the lib.rs explicit statement:

![cfg_attr(test, deny(warnings))]

Which for whatever reason doesn't adequately respond to --cap-lints warn.

If this change set is not valuable, or at least, if not all changes are deemed valuable, this PR may still be helpful for other linux vendors who have the same sort of concerns about demonstrable usability.

If some changes in this are not quite up to standard, please ensure to give some sort of opportunity to rectify them before closing this PR.

@kentfredric
Copy link
Author

Tests are now passing on all but 1.0.0, which is broken because it can't sync cargo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant