This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Make rustc-serialize fully portable #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be really nice if this was merged. Anything blocking it? cc @alexcrichton @dtolnay |
|
I have published these and other changes as the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that rustc-serialize compiles and has reasonable behavior on all platforms.
Even though rustc-serialize is deprecated, it's a cornerstone of the Rust crates ecosystem. Popular projects such as RLS and rust-crypto depend on it. Not supporting all platforms hampers the growth of new platforms (WebAssembly, SGX, etc.) in favor of existing platforms.
This PR should be a one-time fix for all future platforms that Rust might support in the future.
Fixes #190
Fixes #191
Fixes #194