This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Replace std::error::Error with core_error::Error #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To promote compatibility across error-handling crates, use core_error::Error as the StdError trait. When using the std feature, core_error simply reexports the std crate. Otherwise, it provide its own Error trait with all the std-only features removed, and implements the trait on all the error structs found in libcore. This PR brings two immediate benefits to no_std users: It makes the Compat struct into a proper compatibility layer, and it makes the core errors compatible with the Fail trait.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
Use
core_error::Error, a compatibility Error trait inno_stdenvironment allowing interoperability between various error handling crates, such as snafu. In std environment,core_errorsimply reexportsstd::error, so this change should be invisible to std users.In particular this change does two things:
Failon everycore_error::Errorerror.core_error::ErroronCompat.It also replaces other usage of
std::error::Errortocore_error::Error, but those should have no visible effect.This is a preliminary PR to get some feedback. In particular, I'm not sure where to document the changes. no_std documentation is pretty scarce in failure.