This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Fix compat Error conversion #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnderEnder
force-pushed
the
compat_fix
branch
from
c2b8a07
to
fc65810
Compare
|
Drat, sorry about that breakage. Thanks for the fix. |
|
@davidbarsky @mitsuhiko if 0.1.4 breaks semver compatibility, perhaps it should be yanked (and the other changes published as 0.1.5)? |
|
@lucab going to publish 0.1.5 now. Not sure if yanking is a good idea. |
|
Yanking is definitely a good idea. It's a clear signal that it's broken. Yanking doesn't remove the package, it just hides it from public view. If someone has a dependency on 0.1.4 (in cargo.lock or whatever), it will still work properly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest failure(0.1.4) breaks failure Error to std Error (without send and sync) conversion. The changes are related to #283
This PR adds: