Skip to content

Commit

Permalink
Auto merge of rust-lang#84130 - Aaron1011:fix/none-delim-lookahead, r…
Browse files Browse the repository at this point in the history
…=petrochenkov

Fix lookahead with None-delimited group

Fixes rust-lang#84162, a regression introduced by rust-lang#82608.
  • Loading branch information
bors committed Apr 14, 2021
2 parents 7537b20 + c6d67f8 commit 16bf626
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 8 deletions.
39 changes: 31 additions & 8 deletions compiler/rustc_parse/src/parser/mod.rs
Expand Up @@ -930,15 +930,38 @@ impl<'a> Parser<'a> {
}

let frame = &self.token_cursor.frame;
match frame.tree_cursor.look_ahead(dist - 1) {
Some(tree) => match tree {
TokenTree::Token(token) => looker(token),
TokenTree::Delimited(dspan, delim, _) => {
looker(&Token::new(token::OpenDelim(*delim), dspan.open))
}
},
None => looker(&Token::new(token::CloseDelim(frame.delim), frame.span.close)),
if frame.delim != DelimToken::NoDelim {
let all_normal = (0..dist).all(|i| {
let token = frame.tree_cursor.look_ahead(i);
!matches!(token, Some(TokenTree::Delimited(_, DelimToken::NoDelim, _)))
});
if all_normal {
return match frame.tree_cursor.look_ahead(dist - 1) {
Some(tree) => match tree {
TokenTree::Token(token) => looker(token),
TokenTree::Delimited(dspan, delim, _) => {
looker(&Token::new(token::OpenDelim(*delim), dspan.open))
}
},
None => looker(&Token::new(token::CloseDelim(frame.delim), frame.span.close)),
};
}
}

let mut cursor = self.token_cursor.clone();
let mut i = 0;
let mut token = Token::dummy();
while i < dist {
token = cursor.next().0;
if matches!(
token.kind,
token::OpenDelim(token::NoDelim) | token::CloseDelim(token::NoDelim)
) {
continue;
}
i += 1;
}
return looker(&token);
}

/// Returns whether any of the given keywords are `dist` tokens ahead of the current one.
Expand Down
15 changes: 15 additions & 0 deletions src/test/ui/macros/none-delim-lookahead.rs
@@ -0,0 +1,15 @@
// check-pass

macro_rules! make_struct {
($name:ident) => {
#[derive(Debug)]
struct Foo {
#[cfg(not(FALSE))]
field: fn($name: bool)
}
}
}

make_struct!(param_name);

fn main() {}

0 comments on commit 16bf626

Please sign in to comment.