Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoalesceBy: missing field in Debug #864

Merged

Conversation

Philippe-Cholet
Copy link
Member

Very quick PR. Yet another missing field just like in #860. The bounds were right for this field to be there.

I thought I successfully went through all our Debug implementations.. well I did it again. I do not see another mistake.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0411d6) 93.78% compared to head (3c33b08) 93.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   93.78%   93.75%   -0.03%     
==========================================
  Files          48       48              
  Lines        6696     6696              
==========================================
- Hits         6280     6278       -2     
- Misses        416      418       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@phimuemue phimuemue added this pull request to the merge queue Jan 25, 2024
Merged via the queue into rust-itertools:master with commit 00998a4 Jan 25, 2024
13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the fix-debug-coalesceby branch January 25, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants