Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the return type of at_most_one() to AtMostOneResult #708

Closed
wants to merge 3 commits into from
Closed

Change the return type of at_most_one() to AtMostOneResult #708

wants to merge 3 commits into from

Conversation

pickx
Copy link

@pickx pickx commented Jun 26, 2023

Fixes #707.

I hope this implementation is fine - any suggestions or changes are welcome.

@phimuemue phimuemue mentioned this pull request Jun 26, 2023
Closed
@phimuemue
Copy link
Member

I'm hesitant to merge this (please see #707 (comment) for details).

@phimuemue
Copy link
Member

Closed as per #707.

@phimuemue phimuemue closed this Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

at_most_one should have a different return type
2 participants
@pickx @phimuemue