Add Itertools::enumerate_ok #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you say more about why you think this particular combination is common enough to belong in (The code itself is fine, though could be improved with a few things, such as |
Squashed commit of the following: commit 146fb0e Author: NoneTheWisr <12655815+NoneTheWisr@users.noreply.github.com> Date: Sun Jan 16 12:44:41 2022 +0400 mob next [ci-skip] [ci skip] [skip ci] commit aa2db90 Author: NoneTheWisr <12655815+NoneTheWisr@users.noreply.github.com> Date: Sun Jan 16 12:19:55 2022 +0400 mob next [ci-skip] [ci skip] [skip ci] commit f473fee Author: Saatvik Shah <6854735+saatvikshah@users.noreply.github.com> Date: Sun Jan 16 09:09:32 2022 +0100 mob next [ci-skip] [ci skip] [skip ci] commit ff4628c Author: Preet Dua <615318+prabhpreet@users.noreply.github.com> Date: Sat Jan 15 23:58:18 2022 -0800 mob next [ci-skip] [ci skip] [skip ci] commit 90bdeb6 Author: NoneTheWisr <12655815+NoneTheWisr@users.noreply.github.com> Date: Sun Jan 16 11:46:53 2022 +0400 mob next [ci-skip] [ci skip] [skip ci] commit 7044ed3 Author: Shahar Dawn Or <mightyiampresence@gmail.com> Date: Sat Jan 15 16:58:27 2022 +0700 mob next [ci-skip] [ci skip] [skip ci] commit 659639e Author: NoneTheWisr <12655815+NoneTheWisr@users.noreply.github.com> Date: Sat Jan 15 13:54:21 2022 +0400 mob next [ci-skip] [ci skip] [skip ci] commit a305d97 Author: Preet Dua <615318+prabhpreet@users.noreply.github.com> Date: Sat Jan 15 01:43:33 2022 -0800 mob next [ci-skip] [ci skip] [skip ci] commit f08c2af Author: Roland Fredenhagen <dev@modprog.de> Date: Sat Jan 15 10:33:59 2022 +0100 mob next [ci-skip] [ci skip] [skip ci] commit 48bd032 Author: Shahar Dawn Or <mightyiampresence@gmail.com> Date: Sat Jan 15 16:22:06 2022 +0700 mob next [ci-skip] [ci skip] [skip ci] commit db02884 Author: NoneTheWisr <12655815+NoneTheWisr@users.noreply.github.com> Date: Sat Jan 15 13:10:44 2022 +0400 mob next [ci-skip] [ci skip] [skip ci] Co-authored-by: Saatvik Shah <6854735+saatvikshah@users.noreply.github.com> Co-authored-by: Roland Fredenhagen <dev@modprog.de> Co-authored-by: Shahar Dawn Or <mightyiampresence@gmail.com> Co-authored-by: Preet Dua <615318+prabhpreet@users.noreply.github.com>
NoneTheWisr
force-pushed
the
enumerate_ok
branch
from
479b4c4
to
27f1fb1
Compare
|
@scottmcm here's an example. I hope it's not made too unreadable by the awkward attempt at de-duplication which turned out to produce quite a bit of type-wrangling: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was done as an exercise in a group that studies Rust in the format of mob programming.
Please let us know whether this seems appropriate for the itertools crate.
By the way, if anyone would like to study Rust in the format of mob programming consider learning more about it here: https://mobusoperandi.zulipchat.com/
Co-authored-by: Saatvik Shah 6854735+saatvikshah@users.noreply.github.com
Co-authored-by: Roland Fredenhagen dev@modprog.de
Co-authored-by: Shahar Dawn Or mightyiampresence@gmail.com
Co-authored-by: Preet Dua 615318+prabhpreet@users.noreply.github.com