Fix overflow in duplicates size hint #571
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The math for size hint on duplicates would panic (with an overflow) if more elements were pending than remained in the size hint of the input iterator. This wasn't being tested since
pending
is only updated once some elements are advanced from the iterator.This is actually pretty common, since collecting to a vector calls
next
first (before getting the size hint), for some reason related to branch prediction.This adds an explicit test for collecting a vector from duplicates as well as a quick check case that skips elements before checking the size hint. It's not clear why the exhaustive check inside quickcheck wasn't catching this.