Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subtraction overflow in DuplicatesBy size_hint #552

Merged
merged 4 commits into from Aug 16, 2021
Merged

Fix subtraction overflow in DuplicatesBy size_hint #552

merged 4 commits into from Aug 16, 2021

Commits on Aug 16, 2021

  1. Fix subtraction overflow in DuplicatesBy size_hint

    @arpankapoor
    arpankapoor committed Aug 16, 2021
    Copy the full SHA
    514af56 View commit details
    Browse the repository at this point in the history

  2. Use saturating_sub as per clippy warning

    @arpankapoor
    arpankapoor committed Aug 16, 2021
    Copy the full SHA
    5f0e1bb View commit details
    Browse the repository at this point in the history

  3. Add test for subtraction overflow in DuplicatesBy

    @arpankapoor
    arpankapoor committed Aug 16, 2021
    Copy the full SHA
    9e2531c View commit details
    Browse the repository at this point in the history

  4. Make hi calculation clearer in DuplicatesBy size_hint

    @arpankapoor
    arpankapoor committed Aug 16, 2021
    Copy the full SHA
    4a14bf7 View commit details
    Browse the repository at this point in the history