Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position max, min and minmax methods #412

Merged
merged 3 commits into from Mar 1, 2020
Merged

Position max, min and minmax methods #412

merged 3 commits into from Mar 1, 2020

Commits on Feb 16, 2020

  1. Add position_{max, max_by_key, max_by, min, min_by_key, min_by} 

    The max functions use Iterator::max_by, while the min functions use
Iterator::min_by.
    @tspiteri
    tspiteri committed Feb 16, 2020
    Copy the full SHA
    c5bfe23 View commit details
    Browse the repository at this point in the history

  2. Add position_{minmax, minmax_by_key, minmax_by} 

    The implementation uses minmax::minmax_impl rather than
Itertools::minmax_by, so that the comparison constraint is relaxed to
PartialOrd, just like for the minmax functions.
    @tspiteri
    tspiteri committed Feb 16, 2020
    Copy the full SHA
    8a5fe0b View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Jack Wrenn <johnswrenn@gmail.com>
    @tspiteri @jswrenn
    tspiteri and jswrenn committed Feb 29, 2020
    Copy the full SHA
    cb66dd8 View commit details
    Browse the repository at this point in the history