Update libFuzzer to llvm/llvm-project@60e32a1 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ never remember if we have this set up here or not... (we also will need to update our test suite sometime down the line for new pass names I bet) |
|
Configuration problem: |
|
Need to switch |
Manishearth
approved these changes
Jan 25, 2022
fitzgen
force-pushed
the
update-libfuzzer-60e32a1
branch
from
9351a54
to
55faf5a
Compare
|
Linking issues in CI. Not totally sure what's going on here. https://github.com/rust-fuzz/libfuzzer/runs/4930210184?check_suite_focus=true#step:5:74 |
|
@fitzgen I get the same error when trying to compile master. A workaround is to add |
|
Which means we would probably need to add it to And that is going to slow down build times too. Very much not ideal. Would prefer to figure out how to fix these linker errors without resorting to a single codegen unit, but I don't have time to dig into this myself right now. |
|
I tried to take a look but linker errors are a bit outside my area of expertise. But I did found another strange bug, see #90. |
This is not ideal, but it does provide two things: 1. It fixes bizarre linker errors about missing `sancov` symbols. 2. It allows LLVM to do inlining that it otherwise refuses to do. For some reason, when sanitizers are enabled, LLVM refuses to inline across codegen units. This is a problem because trivial methods like `Vec::len` won't be inlined, resulting in 100x slowdowns. `cargo fuzz` already restricts its builds to a single codegen unit, so we might as well do the same thing in CI here.
fitzgen
force-pushed
the
update-libfuzzer-60e32a1
branch
from
3c309da
to
d4d1c46
Compare
|
Okay I pushed a commit to do This is not ideal, but it does provide two things:
|
|
Success! |
alexcrichton
added a commit
to alexcrichton/libfuzzer
that referenced
this pull request
Mar 3, 2022
This commit migrates CI to using the `cargo fuzz` binary with its settings for compiling Rust code to avoid mismatches like the codegen unit issue found in rust-fuzz#89
alexcrichton
added a commit
to alexcrichton/libfuzzer
that referenced
this pull request
Mar 3, 2022
This commit migrates CI to using the `cargo fuzz` binary with its settings for compiling Rust code to avoid mismatches like the codegen unit issue found in rust-fuzz#89
|
FWIW there's some more info about the 1 cgu issue at rust-fuzz/cargo-fuzz#215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #88