cleaned-up code, published on crates.io #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedigi
commented
Sep 11, 2019
gedigi
commented
- added description
- replaced deprecated function
- formatted code
- published on crates.io (https://crates.io/crates/libfuzzer-sys)
nagisa
reviewed
Sep 11, 2019
| @@ -1,35 +1,37 @@ | |||
| extern "C" { | |||
| #![allow(improper_ctypes)] // we do not actually cross the FFI bound here | |||
| #![allow(improper_ctypes)] // we do not actually cross the FFI bound here | |||
There was a problem hiding this comment.
yeah you're right... that's cargofmt's fault. I moved things around so it's prettier.
libfuzzer-sys was consciously not published, but I guess it doesn’t matter either way, as long as the ownership of the crate belongs to the same owners as the |
|
Uh, yeah, please add further owners to the crate. (Me, nagisa, frewsxcv) |
gedigi
changed the title
|
@nagisa the README suggested otherwise, that's why I published it: @Manishearth done. btw, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.