Fix int_in_range using more bytes than necessary #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`offset` counts the number of bytes but the range is shifted as if it counted the number of bits. This causes int_in_range to consume more bytes than necessary. The `int_in_range::<u32>(0..=u8::MAX)` case from the new test fails without this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offsetcounts the number of bytes but the range is shifted as if itcounted the number of bits. This causes int_in_range to consume more
bytes than necessary.
The
int_in_range::<u32>(0..=u8::MAX)case from the new test failswithout this commit.