Empty Unstructured::choose param should return Err, not panic. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
force-pushed
the
frewsxcv-choose
branch
from
db852a8
to
d3cee6f
Compare
frewsxcv
force-pushed
the
frewsxcv-choose
branch
from
d3cee6f
to
225d439
Compare
nagisa
approved these changes
Feb 6, 2021
Manishearth
approved these changes
Feb 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing @fitzgen's comment: #62 (comment)
I chose to return an
Errinstead ofResult<Option<T>>since that's an extra layer of clunk. Thoughts?