Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customization of fields on derive #129

Merged
merged 13 commits into from
Oct 20, 2022
Merged

Support customization of fields on derive #129

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
193341a
Support customization of fields on derive
greyblake Oct 19, 2022
f73d5f2
Do not use double quotes for arbitrary macro attribute
greyblake Oct 20, 2022
8913ec0
Introduce trybuild to test failing compilation
greyblake Oct 20, 2022
66b12e1
A few improvements in README about regarding #[arbitrary]
greyblake Oct 20, 2022
9dd430d
Run compiletest only if derive feature is on
greyblake Oct 20, 2022
727ab88
Support #[arbitrary(with = ...)] with closures
greyblake Oct 20, 2022
f3225dd
Refactor derive functions return syn::Result<_>
greyblake Oct 20, 2022
fb58d7a
Return syn::Error instead of panic!() in proc_macro
greyblake Oct 20, 2022
8cbad14
Return syn::Error instead of panic!()
greyblake Oct 20, 2022
479da32
Get rid of the rest of panics within determine_field_constructor()
greyblake Oct 20, 2022
2701ed8
Update CHANGELOG.md
greyblake Oct 20, 2022
4fdf16f
Fix compiletest, make it pass on stable (not on nightly)
greyblake Oct 20, 2022
755b8e0
Replace trybuild ui tests with doc tests
greyblake Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/ui/multiple_arbitrary.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
error: Multiple conflicting #[arbitrary] attributes found on field `x`
--> tests/ui/multiple_arbitrary.rs:5:5
|
5 | / #[arbitrary(value = 2)]
6 | | #[arbitrary(value = 3)]
7 | | x: i32,
| |__________^
5 | #[arbitrary(value = 2)]
| ^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the tests won't pass on both nightly and stable at the same time right now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. I got one tests broken on CI, because I was running nightly locally, but CI was running stable.

OK, i'll change it to doc tests then.