New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.8.0 version of ethereum-type #156
Conversation
It looks like @grbIzl hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could merge paritytech/parity-common#217 first and upgrade ethereum-types to 0.8 directly (cc @niklasad1). But bumping versions is not that hard I guess :)
@ordian make sense to me. |
@grbIzl you need to upgrade all crates in workspace at once (derive, contract and cli) |
Yeah, sounds like the best move imo, although I admit I'm hazy on the implications of the |
@dvdplm |
@dvdplm I would prefer to upgrade this first, because I need it to implement changes in ethkey in parity ethereum (after removing code to parity-crypto). I think, we agreed to make these changes before rand upgrade. Yes, most probably we will have to publish ethabi twice, but this will allow to make sequential relatively simple steps. |
ethabi/Cargo.toml
Outdated
@@ -14,7 +14,7 @@ serde_json = "1.0" | |||
serde_derive = "1.0" | |||
tiny-keccak = "1.4" | |||
error-chain = { version = "0.12", default-features = false } | |||
ethereum-types = "0.6.0" | |||
ethereum-types = "0.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.8.0
is published!
ethabi/Cargo.toml
Outdated
@@ -14,7 +14,7 @@ serde_json = "1.0" | |||
serde_derive = "1.0" | |||
tiny-keccak = "1.4" | |||
error-chain = { version = "0.12", default-features = false } | |||
ethereum-types = "0.6.0" | |||
ethereum-types = "0.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ethereum-types = "0.7.0" | |
ethereum-types = "0.8.0" |
Version upgraded in order to use this lib in parity ethereum with the same 0.7.0 version of ethereum-type lib