Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.0 version of ethereum-type #156

Merged
merged 5 commits into from Oct 1, 2019
Merged

0.8.0 version of ethereum-type #156

merged 5 commits into from Oct 1, 2019

Conversation

grbIzl
Copy link
Contributor

@grbIzl grbIzl commented Sep 25, 2019

Version upgraded in order to use this lib in parity ethereum with the same 0.7.0 version of ethereum-type lib

@parity-cla-bot
Copy link

It looks like @grbIzl hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

ethabi/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could merge paritytech/parity-common#217 first and upgrade ethereum-types to 0.8 directly (cc @niklasad1). But bumping versions is not that hard I guess :)

@tomusdrw
Copy link
Contributor

@ordian make sense to me.

@ordian
Copy link
Contributor

ordian commented Sep 25, 2019

@grbIzl you need to upgrade all crates in workspace at once (derive, contract and cli)

@dvdplm
Copy link
Contributor

dvdplm commented Oct 1, 2019

I wonder if we could merge paritytech/parity-common#217 first and upgrade ethereum-types to 0.8 directly (cc @niklasad1). But bumping versions is not that hard I guess :)

Yeah, sounds like the best move imo, although I admit I'm hazy on the implications of the rand upgrade.

@tomusdrw
Copy link
Contributor

tomusdrw commented Oct 1, 2019

@dvdplm rand is basically used for one method of hash type (to generate a random hash). I don't think it has a huge impact at all. I would be even more inclined to actually remove it from the API as it doesn't seem super useful outside of test code anyway.

@grbIzl
Copy link
Contributor Author

grbIzl commented Oct 1, 2019

@dvdplm I would prefer to upgrade this first, because I need it to implement changes in ethkey in parity ethereum (after removing code to parity-crypto). I think, we agreed to make these changes before rand upgrade. Yes, most probably we will have to publish ethabi twice, but this will allow to make sequential relatively simple steps.

@@ -14,7 +14,7 @@ serde_json = "1.0"
serde_derive = "1.0"
tiny-keccak = "1.4"
error-chain = { version = "0.12", default-features = false }
ethereum-types = "0.6.0"
ethereum-types = "0.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.8.0 is published!

@@ -14,7 +14,7 @@ serde_json = "1.0"
serde_derive = "1.0"
tiny-keccak = "1.4"
error-chain = { version = "0.12", default-features = false }
ethereum-types = "0.6.0"
ethereum-types = "0.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ethereum-types = "0.7.0"
ethereum-types = "0.8.0"

@grbIzl grbIzl changed the title 0.7.0 version of ethereum-type 0.8.0 version of ethereum-type Oct 1, 2019
@dvdplm dvdplm merged commit 9004cc1 into master Oct 1, 2019
@dvdplm dvdplm deleted the NewEthereumTypesBump branch October 1, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants