Fix interrupt::free() unsoundness on multicore systems.
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't be a breaking change since Edition 2021 came out in Rust 1.56, and MSRV is already higher than that (Rust 1.59)
This is unsound on multicore systems because it only disables interrupts in the current core. For multicore chips, a chip-specific critical section implementation is needed instead. Unsoundness is fixed by not returning the `CriticalSection` token. This is a breaking change.
dkhayes117
approved these changes
Aug 21, 2022
Disasm
reviewed
Aug 22, 2022
| @@ -6,7 +6,10 @@ | |||
| /// at most once in the whole lifetime of the program. | |||
| /// | |||
| /// # Note | |||
| /// this macro is unsound on multi-core systems | |||
| /// | |||
| /// this macro requires a `critical-section` implementation to be set. For single core systems, you can | |||
There was a problem hiding this comment.
Maybe feature-gate this macro with critical-section-single-core?
There was a problem hiding this comment.
The macro can still be used if critical-section-single-core is not enabled, if the user supplies a c-s implementation from somewhere else (such as a chip-specific impl for a multicore chip, from its HAL crate).
|
Folded into #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #109, #110
This is unsound on multicore systems because it only disables interrupts in the
current core. For multicore chips, a chip-specific critical section implementation
is needed instead.
Unsoundness is fixed by not returning the
CriticalSectiontoken.This is a breaking change.
This is the riscv equivalent of rust-embedded/cortex-m#447