Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bus: make constructors set CS high. #594

Merged
merged 1 commit into from Apr 23, 2024
Merged

bus: make constructors set CS high. #594

merged 1 commit into from Apr 23, 2024

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Apr 23, 2024

This avoids a footgun where a HAL makes OutputPins low by default (or the user sets
them to low and doesn't notice).

Discussed in today's WG meeting.

@Dirbaio
bus: make constructors set CS high.
bae4c27 
This avoids a footgun where a HAL makes OutputPins low by default (or the user sets
them to low and doesn't notice).
@Dirbaio Dirbaio requested a review from a team as a code owner April 23, 2024 20:12
eldruin
eldruin approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I do not like that a constructor has side-effects, even worse, potentially fallible ones.
However, I agree with the overall assessment in the meeting.

@eldruin eldruin added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit 7e3594e Apr 23, 2024
16 checks passed
@eldruin eldruin deleted the set-cs-high branch April 23, 2024 20:21
@eldruin eldruin mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dirbaio @eldruin