e-h-bus: Adding AtomicDevice for I2C and SPI bus sharing in multiple interrupt contexts
#579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Mar 7, 2024
| } | ||
| } | ||
|
|
||
| unsafe impl<'a, T> Send for AtomicDevice<'a, T> {} |
There was a problem hiding this comment.
I would expect this to be impl Sync, but for some reason if I only do Sync, my test application complains that the AtomicDevice cannot be shared across threads safely.
2 tasks
ryan-summers
changed the title
AtomicDevice for I2C and SPI bus sharing in multiple interrupt contexts
|
you didn't check "allow maintainers to push", i've pushed some fixes to #593 |
|
Thanks for taking this over and pushing it through! :) I didn't see the maintainer allow button, my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a primitive for sharing an I2C or SPI bus across multiple threads where the synchronization scheme is managed externally (i.e. RTIC sync resources).
The user is returned an
Error::Busyif they ever attempt to pre-empt usage of the bus.CC @Dirbaio as we were talking about this in the Matrix channel yesterday.